Problem/Motivation

The function editor_load() is deprecated in 11.2.0.
See: https://www.drupal.org/node/3509245
There is one usage of the function in: modules/ckeditor5_plugin_pack_templates/src/Form/ContentTemplates/CKEditor5TemplateEntityForm.php
It should be replaced with dependency injection.

Steps to reproduce

Proposed resolution

Replace:
$editor = editor_load($format->id());
with:
$editor = $this->entityTypeManager->getStorage('editor')->load($format->id());

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

lmoeni created an issue. See original summary.

lmoeni changed the visibility of the branch ckeditor5_plugin_pack-3537136/3537136-replace-editor_load-function to hidden.

lmoeni’s picture

Status: Active » Needs review
lmoeni’s picture

Assigned: lmoeni » Unassigned

salmonek made their first commit to this issue’s fork.

salmonek’s picture

Added a deprecated FileSystemInterface::EXISTS_REPLACE replacement. With this change also minimum core requirement is bumped to 10.3. We'll release this update when we'll have a new submodule (in 1.5.0)

salmonek changed the visibility of the branch 1.5.x to hidden.

salmonek changed the visibility of the branch 3537136-replace-editor_load-function to hidden.

salmonek’s picture

Status: Needs review » Reviewed & tested by the community

Rerolled with 1.5.x branch, will be released in 1.5.1

salmonek’s picture

Status: Reviewed & tested by the community » Fixed

Released in 1.5.1

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.