Problem/Motivation

I believe we can change the danrod96-new/bootstrap library to entreprise7pro/bootstrap , since the new release of entreprise7pro/bootstrap fork has all that this theme needs, no need to use my fork anymore. Besides, the jQuery Deprecated Functions modules covers the issue addressed in the bootstrap fork.

Steps to reproduce

N/A

Proposed resolution

Apply the changes in the composer.libraries.json, test the slideshow, the mobile menu and other items.

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#14 3536979-test.png1.5 MBdanrod

Issue fork sshop-3536979

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

danrod created an issue. See original summary.

danrod’s picture

Issue summary: View changes
danrod’s picture

Issue summary: View changes
danrod’s picture

Title: Change danrod96-new/bootstrap to » Change library danrod96-new/bootstrap to entreprise7pro/bootstrap
danrod’s picture

Issue summary: View changes

danrod’s picture

I created a new MR to address this, and some documentation changes of course, I'll merge it to the 8.x-1.x-dev branch and try the installation on a fresh Drupal instance to see if it works.

danrod’s picture

Issue summary: View changes
danrod’s picture

It seems like the latest release of the Bootstrap theme already comes with entreprise7pro/bootstrap , so a bit of refactoring is needed to integrate it with the theme. I'll create a new branch for that.

  • danrod committed 53985ecc on 8.x-1.x
    Resolve #3536979 "Bootstrap dependencies"
    
danrod’s picture

I merged a few more changes, this should fix it, I'll make a final test.

danrod’s picture

StatusFileSize
new1.5 MB

It seems to be working now:

New Library Test

And I've updated the documentation: Finally, Copy the bootstrap directory (which should be there already) located at `/vendor/entreprise7pro/bootstrap` to the `/web/libraries` directory.

I'll set it to "Needs Review" just in case anyone wants to test it.

danrod’s picture

Status: Active » Needs review
danrod’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.