The restriction in AccessUnpublishedForm whereby it only appears if the form definition is in ['edit', 'default'] prevents the form from appearing on the Mercury editor form.

I think the decision to opt into some forms rather than out of some forms (like delete) is a good one, because there aren't many forms to edit publishable content. Mercury editor is a new and important one, so I'm submitting a patch to add that.

CommentFileSizeAuthor
#2 3536927-2-mercury-edit-form.patch681 bytesransomweaver

Issue fork access_unpublished-3536927

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ransomweaver created an issue. See original summary.

ransomweaver’s picture

ransomweaver commented
StatusFileSize
new 3536927-2-mercury-edit-form.patch681 bytes

Here is the patch

kul.pratap’s picture

kul.pratap commented
Assigned: Unassigned » kul.pratap

Creating MR for this.

kul.pratap opened merge request !25

kul.pratap’s picture

kul.pratap commented
Assigned: kul.pratap » Unassigned
Status: Active » Needs review
darby3’s picture

darby3
he/him
commented

Initial test suggests the patch here works for my needs.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented

While I suspect this is a great feature for Mercury Editor... I'm wondering how many more changes and features will be needed to continue to support this other contrib infrastructure. It also complicates testing quite a bit.

Is there any way we can make this it's own project to marry the 2?

I get the patch is tiny and it might seem like nothing now to add that functionality. But this module struggles getting attention already... Offloading that onto another maintainer would be ideal.

mably’s picture

mably commented

An alter hook could be useful here.

Will create an MR.

mably opened merge request !42

mably’s picture

mably commented

MR 42 implements the new hook_access_unpublished_allowed_operations_alter hook.

Covered by a kernel test.

ransomweaver’s picture

ransomweaver commented

Works great, thanks! RTBC for the alter hook.

mably’s picture

mably commented
Status: Needs review » Reviewed & tested by the community
mably’s picture

mably commented
Version: 8.x-1.6 » 8.x-1.x-dev
Category: Bug report » Feature request

  • mably committed 73fad773 on 8.x-1.x 
    feat: #3536927 Make AccessUnpublishedForm appear on Mercury Editor node...
mably’s picture

mably commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.