Overview

Follow-up to #3503412: Allow Content Author to set site's homepage from navigator
Staged updates will remain after their target entities have been deleted and after modules that provide the target config are uninstalled

Proposed resolution

Expand what \Drupal\experience_builder\AutoSave\AutoSaveManager::onXbConfigEntitySave() does (in the case of target config entities getting deleted) and implement hook_modules_uninstalled() to delete StagedConfigUpdates targeting uninstalled modules' simple config.

User interface changes

Issue fork experience_builder-3536825

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tedbow created an issue. See original summary.

tedbow credited wim leers.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

Crediting @wim leers for detailing the solution in #3503412: Allow Content Author to set site's homepage from navigator

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Title: Delete Staged Config updates when target config delete and on module uninstall » Delete Staged Config updates when target config are deleted and on module uninstall
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Assigned: Unassigned » penyaskito

penyaskito opened merge request !1330

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Assigned: penyaskito » tedbow
Status: Active » Needs review

Ready for review.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Failing test-only CI 👍

I had only nits. Over to @tedbow for final approval given this is firmly in the Auto-save component :)

  • tedbow committed ac6d610f on 1.x authored by penyaskito 
    Issue #3536825 by penyaskito, wim leers, tedbow: Delete Staged Config...
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: tedbow » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.