Problem/Motivation

Evaluation is a required field, so it is not possible to leave a comment on a activity without also scoring it.

Steps to reproduce

Proposed resolution

Make Evaluation field unrequired.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork lms-3536622

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

luke pekrul created an issue. See original summary.

graber made their first commit to this issue’s fork.

graber’s picture

graber commented
Assigned: Unassigned » graber
graber’s picture

graber commented
Version: 1.0.8 » 1.0.x-dev
Assigned: graber » Unassigned
Status: Active » Needs review

graber opened merge request !108

catch’s picture

catch
he/him
Primary language English
commented

This looks good - one small comment on the MR.

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Manually tested and this is working fine - comment can be added on commit.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Added the extra comments and merged the MR, thanks!

phpstan isn't passing at the moment but I think that's phpstan changes with 11.2 and nothing specific to the MR.

  • catch committed 259ec71b on 1.0.x authored by graber 
    #3536622 Allow commenting without setting score

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.