A patch to address d11 upgrade requirements:

* core_version_requirement updated
* composer.json updated (rector wants this)
* #drupal-off-canvas renamed to #drupal-off-canvas-wrapper
* `->accessCheck(false)` added to entity queries as it's now required.

Fork instructions too complicated, so attaching patch.

CommentFileSizeAuthor
#7 uswds_blb_drupal11-4.patch344.1 KBharry slaughter
#6 uswds_blb_drupal11-3.patch343.41 KBharry slaughter
#4 uswds_blb_drupal11-2.patch343.41 KBharry slaughter
uswds_blb_drupal11.patch344.52 KBharry slaughter

Issue fork uswds_blb_configuration-3536149

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

harry slaughter created an issue. See original summary.

harry slaughter’s picture

harry slaughter
Location Omaha NE USA
commented

This patch doesn't work when I apply this version.

harry slaughter’s picture

harry slaughter
Location Omaha NE USA
commented

I've updated the patch and now it should work. How do I add a patch here?

harry slaughter’s picture

harry slaughter
Location Omaha NE USA
commented
StatusFileSize
new uswds_blb_drupal11-2.patch343.41 KB
smustgrave’s picture

smustgrave commented

Patches should be in MRs for his project probably needs gitlab file too

harry slaughter’s picture

harry slaughter
Location Omaha NE USA
commented
StatusFileSize
new uswds_blb_drupal11-3.patch343.41 KB
harry slaughter’s picture

harry slaughter
Location Omaha NE USA
commented
StatusFileSize
new uswds_blb_drupal11-4.patch344.1 KB
kul.pratap’s picture

kul.pratap commented

Creating MR for this patch.

kul.pratap opened merge request !37

kul.pratap’s picture

kul.pratap commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Has pipeline issues

kul.pratap’s picture

kul.pratap commented
Status: Needs work » Needs review

I have fixed the pipeline issues.

Please review.

harry slaughter’s picture

harry slaughter
Location Omaha NE USA
commented

Sorry, I'm not familiar with the newish gitlab process.

soothmidas made their first commit to this issue’s fork.

soothmidas opened merge request !38

smustgrave closed merge request !38

smustgrave closed merge request !37

  • smustgrave committed d488b322 on 3.1.x 
    feat: #3536149 Drupal 11 Upgrade

By: @hlslaughter
By: @kulpratap2002
smustgrave’s picture

smustgrave commented
Version: 3.0.0 » 3.1.x-dev
Status: Needs review » Fixed

@soothmidas there was already a green MR to address this so work should of continued there if related to D11. Started a new 3.1.x branch and will get a D11 release out shortly

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

smustgrave’s picture

smustgrave commented

Did a release but will admit I don't have much time for this module as I haven't used it in years on a project. It really does need a lot of work still. CSS auditing, plugin reviews, etc. But D11 version is there.

soothmidas’s picture

soothmidas commented

@smustgrave wow, thanks for the very quick response.

This is my first time contributing back to a module via the new GitLab process so I am still learning a lot. I saw that things were failing for the linters so I was looking into correcting those but I guess this isn't the branch to do that if you have a 3.1.x version for 11. I addressed a lot of items in this branch, so I hope it can help you / totally understand not wanting to support a module you don't use on a regular basis. It has a lot of cool features for Layout Builder in general IMO.

How would you recommend I proceed as I am currently using this for a few projects I manage. I feel that the branch I submitted a MR for has worked out most of the bugs from a frontend standpoint. I had a few things to improve the code that I had not included. But I would think/hope that it might address some of the items you feel need to be updated.

smustgrave’s picture

smustgrave commented

Would need to open separate issues for certain bugs.

Feature requests will be reviewed on a case by case basis if to be included.

soothmidas changed the visibility of the branch feature/d11-compatibility-soothmidas to active.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.