Problem/Motivation

There are warning in the respective pipeline which we can fix:

Proposed resolution

Make the validate pipeline green
We can skip eslint pipeline to avoid any regression
phpcs and stylelint pipeline is covered with https://www.drupal.org/project/acquia_optimize/issues/3538217 (As per the restructure)
cspell pipeline should also be handled as per restructure issue#3538217

Issue fork acquia_optimize-3536086

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ankitv18 created an issue. See original summary.

danrod’s picture

danrod
Location Ottawa
commented
Assigned: Unassigned » danrod

danrod opened merge request !13

danrod’s picture

danrod
Location Ottawa
commented

The list of ESLINT issues is HUGE, are we sure we want to fix this? I'm afraid to break the module: https://git.drupalcode.org/issue/acquia_optimize-3536086/-/jobs/5897568/...

any thoughts? @ankitv18

danrod’s picture

danrod
Location Ottawa
commented

There's some issues with the GilabCI pipelines:

fatal: unable to access 'https://git.drupalcode.org/issue/acquia_optimize-3536086.git/': Failed to connect to git.drupalcode.org port 443 after 130312 ms: Could not connect to server

But all issues are fixed except for the ESLINT and STYLELINT because it's a HUGE list and I don't have a lot time for fixing these.

I'll leave to "Needs Work" and perhaps I'll find some time later. @ankitv18

danrod’s picture

danrod
Location Ottawa
commented
Assigned: danrod » Unassigned
danrod’s picture

danrod
Location Ottawa
commented
Status: Active » Needs work

ankitv18 opened merge request !15

ankitv18 changed the visibility of the branch 3536086-fix-validate-pipeline to hidden.

ankitv18’s picture

ankitv18 commented
Issue summary: View changes
Status: Needs work » Needs review
Parent issue: » #3538217: Node edit page Acquia Optimize Functional restructure
danrod’s picture

danrod
Location Ottawa
commented

Thanks a lot for fixing the ESLINT and STYLEINT issues, @ankitv18

vishalkhode made their first commit to this issue’s fork.

vishalkhode’s picture

vishalkhode commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.