Follow-up to:
#3535380: Make testimonial field support limited HTML to demonstrate CKEditor
to add CKEditor to the starshot-paragraph component
Update starshot-paragraph code like that one
Update code, test, and merge
The Paragraph component will use CKEditor
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | sdds-xb-ckeditor-property-testing.png | 2.26 MB | kristen pol |
| #8 | Screenshot 2025-07-14 at 19.21.59.png | 1.41 MB | gábor hojtsy |
| #8 | Screenshot 2025-07-14 at 19.21.30.png | 965.88 KB | gábor hojtsy |
| #7 | Screenshot 2025-07-14 at 19.12.25.png | 101.15 KB | gábor hojtsy |
| #7 | Screenshot 2025-07-14 at 19.07.59.png | 82.75 KB | gábor hojtsy |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
kristen polComment #3
kristen polWhile CKEditor is working, it is hijacking the styles, so that the theme (light/dark) and style props aren't working... so something else is needed
Comment #4
kristen polComment #5
kristen polComment #7
gábor hojtsyThe "problem" was that the template has a real HTML paragraph element for this component. Paragraphs can't contain other paragraphs or lists, so the paragraph naturally ends when you enter a list. Then the styling does not apply to that anymore. Once the wrapper is a div, not a paragraph, this is solved. Not semantically very nice but quickly fixed it :D
BEFORE
AFTER (added another list too and picked the strong variant to show it applies to even list items):
Comment #8
gábor hojtsyBTW the testimonial component has the same problem, you may want to fix it here to be a div for the quote not a p too or open a new issue :) That at least is conceptually easier since the quote is not conceptualised as a "paragraph" :)
Current:
After changing to div:
Comment #9
kristen polThanks, looking
Comment #11
kristen polUpdated the css so that links show up with the correct colors
Going to merge
Comment #12
kristen polmerged
Comment #13
kristen poladd context
Comment #14
kristen polclosing