Problem/Motivation

In some cases it makes sense to have no fixed aspect ratio for images. For example if you want to embed an image inside CKEditor.

Proposed resolution

Add a syntax to the aspect ratio configuration and handle the image generation.

Issue fork rift-3535048

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

christian.wiedemann created an issue. See original summary.

d34dman’s picture

d34dman commented

In some cases it makes sense to have no fixed aspect ratio for images. For example if you want to embed an image inside CKEditor.

I am not convinced that image inside a CKEditor is an exception. Since the logic can also be applied to a teaser image which should behave similarly. (If the design calls for variable height image for teasers, so be it!).

Am not against a request to "preserve" original aspect ratio. However, this should be a cautious choice from Site-builder. And your proposal to add this to rift should achieve that.

We need to do a discovery on what needs to be done to make this happen.

christian.wiedemann opened merge request !15

christian.wiedemann’s picture

christian.wiedemann commented

I added a very simple mechanism which checks if the aspect ratio is "scale". We need propably a better ui or should we extend image handling in genera and scale is just a type.

christian.wiedemann’s picture

christian.wiedemann commented
Status: Active » Needs review
d34dman’s picture

d34dman commented

  • d34dman committed 9834f83e on 2.x 
    Issue #3535048 by christian.wiedemann, d34dman: Creating image styles...
d34dman’s picture

d34dman commented

@christian.wiedemann, I have pushed a slightly modified work to 2.x branch. Could you please test it out?
What is pending is, Adding a "nop" as "Preserve original aspect ratio" to the select list. Until then, you would have to add "nop" as an aspect ratio to global settings and use that.

d34dman closed merge request !15

  • d34dman committed 18991d68 on 2.x 
    Issue #3535048 by christian.wiedemann, d34dman: Add "nop - Use original...
d34dman’s picture

d34dman commented
Status: Needs review » Fixed
christian.wiedemann’s picture

christian.wiedemann commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

d34dman’s picture

d34dman commented
Parent issue: » #3540394: Roadmap for 2.0.0