Problem/Motivation

The Core field type 'Datetime Range' is not supported in any Field plugin

Proposed resolution

Add support for Datetime Range field type

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

A plugin is available for Datetime Range fields on /admin/config/content/diff/fields

API changes

None

Data model changes

None

CommentFileSizeAuthor
#4 3534656-4.patch695 bytesidebr

Issue fork diff-3534656

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !139

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request adds support for Datetime Range field type and adds test coverage for the daterange field type

The failures in the next minor are unrelated to this merge request. I created a separate issue to fix these, see #3534698: Fix pipeline failures on next minor (phpstan + phpunit)

idebr’s picture

idebr commented
StatusFileSize
new 3534656-4.patch695 bytes

Patch file for 8.x-1.x for projects running the final version of 8.x-1.x

idebr’s picture

idebr commented
eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Status: Needs review » Reviewed & tested by the community

Looks good. The test verifies the content of the displayed diff. I triggered the test-only pipeline, but that's silliness, of course, since we're not solving a bug. I functionally verified the patch in our project, code changes are minimal.

acbramley’s picture

acbramley commented
Status: Reviewed & tested by the community » Needs work

See MR comments

dennisdk’s picture

dennisdk
Primary language Dutch
commented
Status: Needs work » Reviewed & tested by the community

Thanks! Works as expected!

  • acbramley committed f3a231bf on 2.x authored by idebr 
    [#3534656] feat: Add support for Datetime Range field type

By: idebr
By...
acbramley’s picture

acbramley commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.