Problem/Motivation

The design worked up and submitted in #3524842: UX design for rules list/add/edit should be implemented for the rule add/edit page.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 ruleadd-edit.png97.94 KBswirt

Issue fork alt_text_validation-3534376

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

swirt created an issue. See original summary.

swirt’s picture

swirt
he/him
Primary language English
commented
Assigned: Unassigned » swirt

There were a few items where I deviated from the design#

  1. "This only shows in Drupal" I changed to say "This is only administrative." because it is more precise.
  2. I rearranged the order of the three states in Rule Status to keep the description in the same order as the options (lowest impact to high.
  3. In the rule status I changed "won't allow users to publish" to "won't allow users to save" because save is the event being performed while publishing is often just a change or moderation state.
  4. I moved the rule status up to appear just after the rule label. Otherwise it was always falling between the Rule validation and the dynamic length or comparison text that related to the Rule validation.
swirt’s picture

swirt
he/him
Primary language English
commented
StatusFileSize
new ruleadd-edit.png97.94 KB
swirt’s picture

swirt
he/him
Primary language English
commented

the rule add/edit screen

swirt opened merge request !45

swirt’s picture

swirt
he/him
Primary language English
commented
Assigned: swirt » Unassigned
Status: Active » Needs review

To test

  1. Use the "View live preview" link above
  2. login u:admin p:admin
  3. go to /admin/config/content/alt-text-validation/rules/add
  4. validate it against the design in #3524842: UX design for rules list/add/edit (keeping in mind the list of changes ^^)
kesmith’s picture

kesmith commented

Hi @swirt!
I looked at this today, and I have just a few updates:
- When adding a rule > Rule status > can we change Warn to "Warn allows users to save but displays a warning encouraging them to edit their alt text"? You matched it to what we had in the designs, but in the designs, we had "prevent" listed first so it was clear who the "them" was to start.
- I also noticed that the image doesn't appear in the report if it has a warn and prevent rule applied to it:
So like 'Image of ... ' that's over 100 characters. Because I set the rules to prevent if the alt text contains "image of" it doesn't technically save the image. So I get why it doesn't appear in the report, but just a scenario I hadn't thought about when we were doing the designs - so I'm not sure if it needs to be addressed or not.

I like the changes you made and they make sense! The rest looks good!

  • swirt committed ae15a85b on 1.0.x 
    #3534376 "Implement the design to Rule add/edit UI"
swirt’s picture

swirt
he/him
Primary language English
commented
Status: Needs review » Fixed

@kesmith. Thank you.

I adjusted the warn text to your suggestion. That was a great catch.

Yah if the save never happens it can't show in the report because the report only shows what is actually saved. There is not really a way around that. I also don't think it will be a common use case where people will be avidly watching the report while they are making attempted saves. In most cases I think editors will be handling the saves, and someone else will be utilizing the report. But it can lead to some head scratching moments when trying to test the module like we are doing in development.

swirt’s picture

swirt
he/him
Primary language English
commented
Status: Fixed » Closed (fixed)

Released with 1.0.0-alpha7