Currently it's pretty hard to access third party settings from the field formatter in a custom RiftBuilder plugin, without overwriting large portions of the module. The PictureConfig DTO (used for example in the isApplicable() method) has no support for other values than the hardcoded ones.
Add third party settings to the PictureConfig DTO
Implement the feature
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !8compare changes, plain diff MR !7
Comments
Comment #5
sch4lly commentedComment #6
d34dman commented@sch4lly,
This is indeed a good improvement, Goes along the lines of what I had in mind for 2.x release. Make it more easy to extend via other custom/contrib modules.
I tested this, and it doesn't seems to break anything. However when i run the existing site test on this change, it is failing.
This also points out we need to add some linters into the project.
Is it ok if I put this on hold until I figure out why the tests are failing?
Comment #7
d34dman commentedComment #9
d34dman commentedMade some minor adjustments and got this in.
- Renamed the new method to follow naming patterns for other methods.
- Added an empty "third_part_settings" to default config so that usage without field formatter wont' lead to broken code.
Comment #11
d34dman commented