Overview

When we search any text / word and then press enter the page just reloads, instead we need to figure out if we should just show the searched items or rather on pressing enter should take it to the first searched page.

Also when we search a word and then click outside the navigator Search field is getting empty and shows only one previously searched page

Proposed resolution

TBD

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

deepakkm created an issue. See original summary.

deepakkm’s picture

Issue summary: View changes
deepakkm’s picture

Component: … to be triaged » Theme builder
deepakkm’s picture

Issue summary: View changes
mayur-sose’s picture

Another related issue with search page navigation :

    Steps to reproduce :
  • Open navigator.
  • Type full page title of any page.
  • Click anywhere outside the page and again click on navigator.
wim leers’s picture

Title: Do not allow form to be submitted in the search navigation » Do not allow form to be submitted in the navigator's search funcitonality
Component: Theme builder » Page builder
Issue tags: +JavaScript
jessebaker’s picture

Assigned: Unassigned » jessebaker
Issue tags: -JavaScript +JavaScript

jessebaker’s picture

Assigned: jessebaker » Unassigned
Status: Active » Needs review

MR!1338 addresses both

Pressing enter/submitting the search form reloads the page
Re-opening the Navigator resets the search input value but not the search results.

lauriii’s picture

Issue tags: +backport

  • jessebaker committed 2e34bebe on 1.x
    Issue #3533570 by jessebaker, mayur-sose, deepakkm: Do not allow form to...
jessebaker’s picture

Assigned: Unassigned » balintbrews
Status: Needs review » Patch (to be ported)
mayur-sose’s picture

StatusFileSize
new118.13 KB

@jessebaker, Both of the reported issues have been resolved:

  • Pressing enter or submitting the search form no longer reloads the page.
  • Re-opening the Navigator now resets the search input value as well as the search results.

However, when reopening the Navigator, the search input resets, but the transition is not smooth. Users momentarily see the previous results list before the full list is displayed again. If possible, could we also address this for a smoother user experience?

There is also an issue: unpublished pages appear in the search navigator when the search input value is "untitled page," even though this does not match their titles.

Steps to reproduce:

  1. Create 2-3 pages and do not publish them (for example: xyz, qwerty, abcd).
  2. In the navigation search, enter 'untitled page.' You will see all unpublished pages listed there.
wim leers’s picture

Assigned: balintbrews » jessebaker

For #13 — thanks Mayur!

wim leers’s picture

Assigned: jessebaker » balintbrews
Issue tags: +Needs followup

Discussed in chat and we decided to move forward with this and create a follow-up for #13. @jessebaker's availability is limited today.

jessebaker’s picture

#3537807: Previous page search results flash briefly when opening the Navigator Created a follow up to address #13 "Users momentarily see the previous results list before the full list is displayed again"

Do we need another follow up for the "unpublished pages appear in the search navigator" or is that working as intended?

wim leers’s picture

Thanks, Jesse!

Do we need another follow up for the "unpublished pages appear in the search navigator" or is that working as intended?

That is working as intended, and was introduced in #3518292: Allow searching for content in the navigator, via `/xb/api/v0/content/{entity_type}`.

Mayur explained in chat: If the page titles are set to "xyz" or "qwerty" (and are auto-saved), searching for "untitled page" will still list both pages, even though their titles do not match the search query

My response:

@Mayur Sose that’s expected — because it’s only been named "xyz" in auto-save — the actual underlying SAVED entity is still stored with "Untitled page"


That means this now just needs a simple direct backport. 👍

Thanks everyone!

balintbrews’s picture

Assigned: balintbrews » Unassigned
Status: Patch (to be ported) » Fixed
Issue tags: -JavaScript +JavaScript

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.