Problem/Motivation

Replace annotation-based test metadata with PHP attributes.

Please DO NOT change the MR here manually. The patch is automatically generated by the MR at #3446380: [no-commit] Define a Rector rule to convert test annotations to attributes.

Proposed resolution

In this issue, convert modules' BuildTests.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3533413

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !12569

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
godotislate’s picture

godotislate
he/him
commented
Status: Needs review » Reviewed & tested by the community

I ran these commands:
phpunit --list-tests --group package_manager | grep Package
phpunit --list-tests --group="#slow" | grep Package

on both this MR branch and 11.x and confirmed that the following all show up as expected:

 - Drupal\Tests\package_manager\Build\PackageInstallDirectWriteTest::testPackageInstall
 - Drupal\Tests\package_manager\Build\PackageInstallSubmoduleTest::testSubModules
 - Drupal\Tests\package_manager\Build\PackageInstallTest::testPackageInstall
 - Drupal\Tests\package_manager\Build\PackageUpdateTest::testPackageUpdate

Changes look straightforward. LGTM.

  • catch committed 0f4a4b5a on 11.x 
    Issue #3533413 by mondrake, godotislate: Convert test annotations to...

catch closed merge request !12569

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

mondrake’s picture

mondrake
Location 🇮🇹
commented
Parent issue: #3526490: Convert test annotations to attributes in Drupal/BuildTests » #3535662: [meta] Convert test metadata from annotations to attributes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.