Problem/Motivation

We have both ui_patterns_views/ViewRowsSource and display_builder_views/ViewRowsSource.

Proposed resolution

There must be a reason why this plugin was duplicated, let's see if we have something to change in ui_patterns_views/ViewRowsSource

Can we get rid of context_requirements: ['is_display_builder_views'] which is not existing in UI Patterns 2? Maybe we need to merge this context requirement with views:style from ui_patterns_views/ViewRowsSource (which may be renamed, views:view? views:rows? views:display? but it is an UI Patterns 2 issue).

Remaining tasks

Do we move the source plugins of display_builder_views to ui_patterns_views once we are sure they are compatible? If we do that, let's be careful with #3533043: Expose view sources forms in SourceInterface::settingsForm() and wait for #3533046: Reword plugins ID, label & descriptions.

Issue fork display_builder-3533044

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented
Issue summary: View changes
pdureau’s picture

pdureau commented
Issue tags: +display_builder-1.0.0-beta
pdureau’s picture

pdureau commented
Issue summary: View changes
pdureau’s picture

pdureau commented

Also

On the rendered view : Call to a member function getOption(), sometimes, when we use the UIP2 ViewRows instead of the DB one: may be related to #3533044: Merge the two ViewRowsSource plugins and the issue may be addressed in UI Patterns 2 leve

pdureau’s picture

pdureau commented
Issue tags: -display_builder-1.0.0-beta +display_builder-1.0.0-beta1
mogtofu33’s picture

mogtofu33 commented

I think the problem is the UIP source views rows is assuming it is used only in views context with views settings available.
But in Display builder we don't have (yet?) the views settings, so using the UIP views rows create an error as it want to get the settings.
So probably this should be a UIP modification?

pdureau’s picture

pdureau commented
Assigned: Unassigned » pdureau
Status: Active » Postponed

Let's create a related issue on UIP2 side and resume after that.

pdureau’s picture

pdureau commented
Assigned: pdureau » just_like_good_vibes

Related UI Patterns issue: #3556413: Future proofing views source plugin

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Status: Postponed » Needs work

require #3556413: Future proofing views source plugin

just_like_good_vibes opened merge request !157

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » pdureau
Status: Needs work » Needs review
pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs review » Reviewed & tested by the community

OK for me. To be tested with upcoming UI Patterns 2.0.12.

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.