Problem/Motivation
Performance tests run from scheduled pipeline for 11.2 are not sending open telemetry traces. In 11.2.x / 11.x variable `OTEL_COLLECTOR` is not defined on the parent pipeline here: https://git.drupalcode.org/project/drupal/-/blob/11.x/.gitlab-ci.yml?ref...
This is required to pass variable from pipeline input to child pipeline.
This is set in 10.6.x which explains why those scheduled perf test pipelines are still shipping OTEL.
Steps to reproduce
In 11.2.x running perf test pipeline with OTEL_COLLECTOR configured does not result in any traces.
Proposed resolution
Set OTEL_COLLECTOR var in parent pipeline - I will open MR.
(I targeted issue version at `11.x`, this will need to go into `11.2.x` to resolve issue. This is already set in 11.1.x).
Issue fork drupal-3532871
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3532871-performance-test-otelcollector
changes, plain diff MR !12526
Comments
Comment #3
maxwhiteheadComment #4
maxwhiteheadComment #5
maxwhiteheadComment #6
heddnLGTM
Comment #7
catchThis is a good find - performance tests stopped reporting to the dashboard in 11.2 - was fine with 11.1, and couldn't see a reason why. Moving to needs work while we figure out where we can set this without breaking regular test runs.
Comment #10
catchWent ahead and made a commit here since this is only testable on pipelines. I made the job variable different to the environment variable, so we can pass that around then finally set the real environment variable in the child pipeline. This meant updating the 11.x performance test job to use the new variable name.