Problem/Motivation

ECA will publish a new major in the next couple of weeks. ECA itself doesn't change much, but the whole UI integration will change. So, for modules that provide just plugins to work with ECA, it's safe to extend the version constraint to also allow ECA 3.

Issue fork eca_vbo-3532217

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas opened merge request !4

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Active » Needs review
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Title: Update constraint to allow or ECA 3 » Update constraint to allow for ECA 3
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs review » Needs work

Wait a minute, I'll also update the deprecated namespace.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs work » Needs review

The remaining test failures are unrelated to this MR, so back to NR.

rajab natshah’s picture

rajab natshah
he/him
commented

Facing the same issue.
Thanks for the MR

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires drupal/eca_vbo ^2.1 -> satisfiable by drupal/eca_vbo[2.1.0, 2.1.1, 2.1.x-dev].
    - drupal/eca_vbo[2.1.0, ..., 2.1.x-dev] require drupal/eca ^2.0 -> found drupal/eca[dev-2.0.x, dev-2.1.x, 2.0.0-alpha1, ..., 2.1.x-dev (alias of dev-2.1.x)] but the package is fixed to 3.0.0-rc1 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Hoping for a commit and a tag release

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Major
mxh’s picture

mxh commented
Priority: Major » Normal
Status: Needs review » Needs work

The MR has a red cross sign, something is wrong there.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs work » Needs review

Those test failures are not related to the MR, they would be the same on the current dev branch.

mxh’s picture

mxh commented
Status: Needs review » Needs work

The last commit in 2.1.x branch has green sign, this MR has a red sign. Maybe those checks don't even really make sense, but anyway, they were added once before by you: https://git.drupalcode.org/project/eca_vbo/-/blob/2.1.x/.gitlab-ci.yml?r...

An MR is ready for a review once it has a green sign.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented

Well, this module has last been tested 12 months ago. And it's tested against Drupal 11, which has changed quite a bit in that period.

The module doesn't successfully test against the current version of Drupal 11, and that should be fixes separately, not as part of this issue. The changes in this MR have NOT introduced those failures, they have just been unnoticed before.

mxh’s picture

mxh commented

Well, then we're blocked by those problems. So, we need a separate issue for fixing those problems first, flagging this issue to be blocked by that issue. Once that issue got fixed, then it unblocks this issue and we can continue to fix this issue.

rajab natshah’s picture

rajab natshah
he/him
commented

Hoping for a soft 2.1.2-alpha1 released tag to speed up testing and using in Drupal 11.2

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs work » Needs review

I don't know why I keep getting in the mess where I have to maintain modules that I haven't created. I've now also fixed the tests which failed due to upstream changes in the pipeline configuration and with Drupal core.

Edited: removed inappropriate statement.

rajab natshah’s picture

rajab natshah
he/him
commented

Thanks, Jürgen, for all your work on ECA. (We are learning a lot from your methods)
ECA is huge!!!
We are willing to ditch using 20, maybe 30 modules, and switch to ECA configurations.
In my current case, for VBO and AI under Drupal 11.2 in
#3504027: Add VBO Plugin to Bulk Generate Alt Text for Media Entities
I'm not planning to add a custom plugin or a custom sub-module.
As I see it, ECA VBO will allow us to do more with less code.

  • mxh committed b5519140 on 2.1.x authored by jurgenhaas 
    Issue #3532217 by jurgenhaas: Update constraint to allow or ECA 3
mxh’s picture

mxh commented
Status: Needs review » Fixed

I don't know why I keep getting in the mess where I have to maintain modules that I haven't created.

Expressing this frustration at a project that I maintain mostly in my free time. I once put the efforts creating this project. And instead of keeping it in a private repository, I did put more time into it to achieve common usability and made it deliberately available for everyone. Facing such comments is not nice. And yes, I read your original inappropriate comment.

Looking at the changes required, mostly come from breaking BC from ECA v2 to v3. Complaining to maintainers not keeping up with the ongoing development is like complaining the free beer you got isn't cold enough. If you don't like this project or its maintenance state, go ahead and help improving it, fork it, build your own solution or do nothing. FOSS allows you to do so.

mxh’s picture

mxh commented

Crediting.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.