Problem/Motivation

Fields in the form do not have a preview of the selected icon

Icon

CommentFileSizeAuthor
#3 fontawesome_iconpicker_preview.patch2.39 KBvav33
#2 iconpicker.jpg6.54 KBvav33
fontawesome_iconpicker_preview.patch1.93 KBvav33

Comments

vav33 created an issue. See original summary.

vav33’s picture

vav33 commented
Issue summary: View changes
StatusFileSize
new iconpicker.jpg6.54 KB
vav33’s picture

vav33 commented
StatusFileSize
new fontawesome_iconpicker_preview.patch2.39 KB

  • d34dman committed 865f0a72 on 3.x 
    [#3531392] feat: Adding a preview icon

By: vav33
By: d34dman
d34dman’s picture

d34dman commented

@vav33 thanks for the contribution.

Before committing this patch, I explored an alternative approach using the Drupal renderer, which applies the same technique as the formatter to generate previews. However, that resulted in inconsistencies in the preview, whereas this solution is cleaner.

I’m not entirely happy about the opinionated CSS we need to ship with this feature, but without it the output looks odd in many themes. So I’ll keep it for now.

Thanks for the contribution!

d34dman’s picture

d34dman commented
Version: 3.0.0 » 3.x-dev
Status: Patch (to be ported) » Fixed

This is fixed in 3.x-dev, and would be included in next release.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.