Overview

If the content being rendered by an XB extension is taller than the screen height it pushes the "Close" button off the bottom of the screen and thus the dialog cannot be closed.

Proposed resolution

Move close to X in top right, add max height to extension area, add overflow: scroll or some combo of these things.

User interface changes

I'm using the dev tools to increase the height of the content here to demonstrate the issue

CommentFileSizeAuthor
#6 before.png26.03 KBlibbna
#6 after.png26.53 KBlibbna
2025-06-19 08.53.41.gif238.27 KBjessebaker
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jessebaker created an issue. See original summary.

libbna’s picture

Hi @jessebaker, could you please provide the steps to reproduce this issue?
Once they're available, I'll assign the issue to myself and begin working on it.

wim leers’s picture

Component: Page builder » Extensions API
Priority: Normal » Minor
Issue tags: +JavaScript

jessebaker’s picture

Status: Active » Needs review
Issue tags: -JavaScript +JavaScript

Thanks @libbna for your offer of helping. I had actually already done most of the work when I created this issue so I've got an MR already. My bad for not assigning it to myself when I created it.

libbna’s picture

StatusFileSize
new26.53 KB
new26.03 KB

I installed the xb_test_extension module & have reviewed the MR. The extension dialog is looking good to me. I have added before and after screenshots.

NOTE: from the dev tools I have increased the height to check the scroll bar.

hooroomoo made their first commit to this issue’s fork.

hooroomoo’s picture

Assigned: Unassigned » jessebaker
Status: Needs review » Needs work

Some visual regressions for the existing dialogs should get addressed

jessebaker’s picture

Assigned: jessebaker » hooroomoo
Status: Needs work » Needs review

I'm afraid I don't remember why I added the min-height to the dialogs. I have removed it and everything seems to be working find so I'm going to chalk it up to me trying something that I later backed out of but forgot to remove.

hooroomoo’s picture

hooroomoo’s picture

Assigned: hooroomoo » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.