Problem/Motivation

When migrating from Solr to SearchStax, after migrating the server, and having two search indexes, pressing "Create copy" for the second index always results in the first index being copied.

screenshot of the migration form with the inspector open showing that the second button is related to the first index

Steps to reproduce

Start with a site configured to use Solr and two search indexes.
1. Migrate the Solr server to SearchStax
2. Press the "Create copy" button next to the second index.
3. Notice that when the page reloads, a copy of the first index has actually been created.

Alternatively, inspect the "Create copy" submit buttons in the browser, and note they are not on the correct row.

Proposed resolution

The "Create copy" buttons are reversed on the migration page. Check the logic for building the form to make sure they are placed correctly.

Issue fork searchstax-3530133

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

byrond created an issue. See original summary.

byrond’s picture

Issue summary: View changes
StatusFileSize
new364.15 KB
byrond’s picture

Title: Migration from Solr "Create copy" for indexed buttons are reversed » Migration from Solr indexes "Create copy" buttons are reversed
franckylfs’s picture

StatusFileSize
new328.81 KB

It's exactly the same problem for the views index too.
Migrate issue

drunken monkey made their first commit to this issue’s fork.

drunken monkey’s picture

Status: Active » Needs review

Thanks for reporting, and sorry it took me so long to get back to you!
I could reproduce the problem (after a few tries) and can now see where this is coming from. Should be fixed in this merge request, along with another problem with this form (which can appear when deleting migrated servers/indexes).

Please give it a try!

drunken monkey’s picture

Status: Needs review » Fixed

Merged.
Should now be fixed in the dev snapshot of the module and the fix will also be included in the upcoming 1.7.2 (or 1.8.0) release.

  • drunken monkey committed 626bc362 on 1.x
    [#3530133] fix: Fixed mismatched buttons in "Copy indexes" and "Switch...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.