Overview

Figma

Proposed resolution

User interface changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bnjmnm created an issue. See original summary.

libbna’s picture

StatusFileSize
new28.05 KB

Hi @bnjmnm,
I'd like to give this a try, but I could use some guidance. Could you please clarify where exactly the styling is expected? Based on my understanding (as shown in the attached screenshot), when we create a new component, do we need to apply styles to the fields (props and slots) that we add?

effulgentsia’s picture

"alpha blocker" was a typo. This is a blocker for beta.

bnjmnm’s picture

Status: Active » Needs work
bnjmnm’s picture

Status: Needs work » Needs review

  • bnjmnm committed 0e6e0c78 on 0.x
    Issue #3529623 by bnjmnm, hooroomoo: Style Autocomplete suggestions
    

bnjmnm credited hooroomoo.

bnjmnm’s picture

Status: Needs review » Fixed

The Pipeline fails are due to CI issues installing Cypress dependencies, nothing specific to this MR (the 2nd to most recent had been passing, and the only change in the most recent were stylelint related).

Gonna merge this in now since @hooroomoo already reviewed.

wim leers’s picture

neha_bawankar’s picture

StatusFileSize
new4.09 KB
new3.95 KB
new4.76 KB
new5.56 KB
new15.55 KB

Tested changes on branch 0.x for following scenario :

  1. Create three Articles named : Test , Test01 , Test02
  2. Create code component , add prop o type link
  3. Add Code component to page

Scenario

Result

Status

link prop

test1

PASS

link prop with cursor

test2

PASS

start typing

test3

PASS

Select option

test4

PASS

Tested changes for
https://www.drupal.org/project/experience_builder/issues/3531066

test5

PASS

During testing, an issue was identified: the search dropdown that appears is not scrollable and only displays the first 10 results.
Reported here : Autocomplete suggestions dropdown is not scrollable and only shows the first 10 results

wim leers’s picture

Issue tags: -sprint

Thanks! Followed up there 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.