Do not rewrite outbound URL if the source domain is the active domain

Hi @idebr,

I'm stuck on a functional test that runs fine on current version (D11) but fails on previous major (D10) when executed via a Gitlab CI pipeline.

Test works perfectly fine locally on D11 and on D10.

No idea what the problem could be.

Any help will be greatly appreciated.

For now, I just disabled those 2 assertions when running on D10 in Gitlab CI.

Could you give it a try locally on D10 just to be sure we are not letting something go thru?

After generating some logs on Gitlab CI, I can see that the failing node doesn't seem to have the right domain source defined:

----------------------------------------
Path: /node/1
Active domain: example_com
Langcode: en
Url: route:entity.node.canonical;node=1
Entity id: 1
Source id: example_com

Here is what I get when run locally:

----------------------------------------
Path: /node/1
Active domain: example_com
Langcode: en
Url: route:entity.node.canonical;node=1
Entity id: 1
Source id: four_example_com
Base URL: http://four.local-drupal10.sid.bm

What is rather strange is that we are testing the source just before doing the toString() :

    // Try to post a node, assigned to the second domain.
    $edit = [
      'title[0][value]' => 'Test node',
      'field_domain_source' => $two,
    ];
    $this->drupalGet('node/add/article');
    $this->submitForm($edit, 'Save');
    $this->assertSession()->statusCodeEquals(200);
    $node = $node_storage->load(1);
    // Check that the value is set.
    $value = domain_source_get($node);
    $this->assertEquals($two, $value, 'Node saved with proper source record.');

    // Test the URL.
    $url = $node->toUrl()->toString();
    $expected_url = $two_path . 'node/1';
    $this->assertEquals($expected_url, $url, 'URL rewritten correctly.');

Found the problem after a few hours of debugging.

The test relies on the order of the results of call to loadMultiple().

For some reason, the order is different on Gitlab than locally and the test fails.

Don't know for what reason it has been done like this.

For sure they didn't need to take the active domain into account then.

We do now, and on Gitlab CI, the test domain chosen was simply the already active domain.

So it couldn't work.

Test has been updated to be sure to avoid selecting the currently active domain.

@idebr everything is green again.

Do you want to have a look before I merge?

It's merged. Thanks!