Problem/Motivation

Both sidebars are currently modals:

  • the first is a "normal" sidebar
  • the second is a dropdown from InstanceButtons island

The use localstorage to keep memory of state and size.

This custom code can be replaced by something more generic.

Nice to have: animation. Careful it must not be triggered when restoring the state while refreshing the page.

Proposed resolution

Replace them by shoelace's Drawer.

It is nice if localstorage feature can be kept, but it is OK if it needs be removed.

Issue fork display_builder-3529049

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented
Issue summary: View changes
pdureau’s picture

pdureau commented

Careful to not lose the "close modals with ESC keypress" feature

mogtofu33 made their first commit to this issue’s fork.

mogtofu33 opened merge request !8

  • mogtofu33 committed acedc331 on 1.0.x 
    Issue #3529049 by mogtofu33: Replace sidebars modals by drawers, remove...
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Active » Fixed
mogtofu33’s picture

mogtofu33 commented
Status: Fixed » Closed (fixed)
pdureau’s picture

pdureau commented
Title: [1.0.0-alpha1] Replace sidebars modals by drawers » Replace sidebars modals by drawers
Issue tags: +display_builder-1.0.0-alpha1