Problem/Motivation

PHP 8.4 has been released, and this module is triggering a "use explicit nullable type" deprecation.

This is part of Drupal's coding standards now, but since the issues to fix phpcs in this module have stalled, I'm opening up this issue to fix this single deprecation to avoid the warnings on PHP 8.4.

After updating to PHP 8.4:

PHP Deprecated:  Drupal\ckeditor_bs_grid\Form\GridDialog::buildForm(): Implicitly marking parameter $editor as nullable is deprecated, the explicit nullable type must be used instead in /var/www/html/docroot/modules/contrib/ckeditor_bs_grid/src/Form/GridDialog.php on line 83

Issue fork ckeditor_bs_grid-3528887

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hfernandes created an issue. See original summary.

hfernandes opened merge request !26

hfernandes’s picture

hfernandes commented
Assigned: hfernandes » Unassigned
Status: Active » Needs review

b_sharpe made their first commit to this issue’s fork.

b_sharpe’s picture

b_sharpe commented
Status: Needs review » Fixed

Fixed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.