Increase code quality by respecting coding standards.

Will use 4 tools:
- coder
- phpmd
- phpstan
- rector

Issue fork subentity-3528827

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sylvainm created an issue. See original summary.

sylvainm opened merge request !10

sylvainm’s picture

sylvainm commented

First pass done. It remains some errors which seems to be false positive, imho

sylvainm’s picture

sylvainm commented

Blocked by 3528831

sylvainm’s picture

sylvainm commented
Assigned: sylvainm » Unassigned
Status: Active » Needs review

Done, but the CI fails without explicit error message…

paraderojether’s picture

paraderojether commented
Status: Needs review » Needs work

Hi

I was unable to verify the fix as the CI pipeline is failing. The error should be checked, moving this to Needs work.

Thank you.

liuyuanchao made their first commit to this issue’s fork.

liuyuanchao’s picture

liuyuanchao commented
Status: Needs work » Needs review

Fix the pipelines error. Please review.

paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community

Hi

I reviewed MR!10 again, confirmed the CI pipeline error is fixed, and phpcs is passed on Gitlab CI.

Moving this to RTBC.
Thank you.

maxpah made their first commit to this issue’s fork.

macsim’s picture

macsim commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

macsim’s picture

macsim commented
Status: Fixed » Closed (fixed)