Problem/Motivation

The module currently uses version 1.5.0 of the `lite-youtube` library, while the latest available version is 1.8.2.

Steps to reproduce

Proposed resolution

It would be better to implement a new strategy for managing the library version dependency. A configuration form should be created to allow setting the library version and an alternative CDN URL.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork lite_youtube-3528786

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ruby232 created an issue. See original summary.

jleon1110’s picture

jleon1110 commented

Configuration forms could be used to implement this solution and directly assign the library URL.

jleon1110 opened merge request !6

ruby232’s picture

ruby232 commented

@jleon1110
Thanks for your MR. I’ve reviewed the code and left a few comments.
I believe this MR is missing two important cases:

  • Handling for existing sites
  • Setting a default value

You can add a config/install/lite_youtube.settings.yml file with the default configuration. This file will be loaded when the module is installed and will set the initial values.

Additionally, you need to create a hook update to update the configuration for sites where the module is already installed.

ruby232’s picture

ruby232 commented
Assigned: ruby232 » jleon1110
ruby232’s picture

ruby232 commented
Status: Active » Fixed
ruby232’s picture

ruby232 commented
Status: Fixed » Closed (fixed)