Fix the PHPCS issue for the 8.x-2.x branch [#3528488]

Problem/Motivation

I see a PHPCS issue to fix in the pipeline execution: https://git.drupalcode.org/project/google_calendar_service/-/pipelines/4...

Steps to reproduce

N/A

Proposed resolution

Fix the issue mentioned above

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork google_calendar_service-3528488

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3528488-fix-the-phpcs changes, plain diff MR !29
Check out this branch for the first time

Check out existing branch, if you already have it locally

3 hidden branches

3528488-fix-the-phpcs-8.x-2.x

changes, plain diff MR !27

Check out this branch for the first time

Check out existing branch, if you already have it locally

3528488-fix-phpcs-issue

changes, plain diff MR !28

Check out this branch for the first time

Check out existing branch, if you already have it locally

8.x-1.x

changes, plain diff MR !26

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

4 June 2025 at 20:51

danrod created an issue. See original summary.

Comment #2

danrod

Ottawa

commented 4 June 2025 at 20:51

Issue tags:

+Novice

Comment #3

5 June 2025 at 01:28

julio_retkwa made their first commit to this issue’s fork.

Comment #4

danrod

Ottawa

commented 5 June 2025 at 01:43

@julio_retkwa are you going to take this one?

Comment #5

5 June 2025 at 01:59

julio_retkwa opened merge request !26

Comment #6

julio_retkwa

Portuguese, Brazil

Santa Catarina

commented 5 June 2025 at 02:11

Hi @danrod sorry, yes

I was not aware that you was working on this, sorry for jumping in

Comment #7

5 June 2025 at 02:24

julio_retkwa opened merge request !27

Comment #8

julio_retkwa

Portuguese, Brazil

Santa Catarina

commented 5 June 2025 at 02:50

I created a MR against branch 8.x-2.x-dev but its failing on composer step
https://git.drupalcode.org/issue/google_calendar_service-3528488/-/jobs/...

I'm missing something here?

PS: I see there are some PHPCS issues on branch 1.x should those be addressed as well? Let me know
https://git.drupalcode.org/issue/google_calendar_service-3528488/-/jobs/...

Thanks!

Comment #9

julio_retkwa

Portuguese, Brazil

Santa Catarina

commented 5 June 2025 at 02:50

Status:

Active

» Needs review

Comment #10

danrod

Ottawa

commented 5 June 2025 at 07:02

@julio_retkwa it is ok, work on the branch 8.x-2.x, which is the one I still want to maintain, if possible.

Thanks a lot for your work.

Comment #11

5 June 2025 at 16:55

danrod opened merge request !28

Comment #12

danrod

Ottawa

commented 5 June 2025 at 17:05

Status:

Needs review

» Needs work

Comment #13

danrod

Ottawa

commented 5 June 2025 at 17:08

@julio_retkwa I'm seeing the same composer issues when trying to create a MR against the 8.x-2.x branch, if you have some time to look on it, that would be great, if not, no worries, I'll look on it later.