Problem/Motivation

I selected a 3 column grid. If you don't configure anything on the Choose your layout screen, and you save, you get three columns with no classes, and to the editor, they are full width. It appears broken.

This is because Advanced is the first choice, and I believe with that, you have to click the advanced button and add your own custom classes.

Steps to reproduce

  1. Click the button in CKEditor to open the BS Grid dialog.
  2. Select "Column 3" and click the Next button
  3. On the Choose a layout screen click Save
  4. Verify you do not get 3 columns side by side, but they are stacked instead. If you look at the source, you will see that they have no classes.

Proposed resolution

I propose that the default be changed from Advanced to Equal. That will provide the editor with the expectations of the first screen, and allow for further customization with the other options, then the advanced option at the end.

Steps to validate

  1. Apply the patch, or checkout this MR
  2. Click the button in CKEditor to open the BS Grid dialog.
  3. Select "Column 3" and click the Next button
  4. On the Choose a layout screen click Save
  5. Verify the 3 columns are side by side
  6. Repeat the process, this time expanding a width to verify Equal is selected
  7. Repeat the process and try other settings and advanced to verify the rest of the existing functionality still works.
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

thejimbirch created an issue. See original summary.

thejimbirch’s picture

Issue summary: View changes
Status: Active » Needs review

Merge request added that makes Equal the default, selected choice and moved Advanced to the end.

This way, a user does not have to make make any changes on the layout screen and the grid will render as expected.

thejimbirch’s picture

Issue summary: View changes
thejimbirch’s picture

Patch added from the diff of the MR.

b_sharpe’s picture

Version: 2.1.x-dev » 2.2.x-dev
ruslan piskarov’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed it on my local project, and I think it is a helpful feature request.

b_sharpe’s picture

Status: Reviewed & tested by the community » Fixed

Thanks both!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.