Problem/Motivation
I selected a 3 column grid. If you don't configure anything on the Choose your layout screen, and you save, you get three columns with no classes, and to the editor, they are full width. It appears broken.
This is because Advanced is the first choice, and I believe with that, you have to click the advanced button and add your own custom classes.
Steps to reproduce
- Click the button in CKEditor to open the BS Grid dialog.
- Select "Column 3" and click the Next button
- On the Choose a layout screen click Save
- Verify you do not get 3 columns side by side, but they are stacked instead. If you look at the source, you will see that they have no classes.
Proposed resolution
I propose that the default be changed from Advanced to Equal. That will provide the editor with the expectations of the first screen, and allow for further customization with the other options, then the advanced option at the end.
Steps to validate
- Apply the patch, or checkout this MR
- Click the button in CKEditor to open the BS Grid dialog.
- Select "Column 3" and click the Next button
- On the Choose a layout screen click Save
- Verify the 3 columns are side by side
- Repeat the process, this time expanding a width to verify Equal is selected
- Repeat the process and try other settings and advanced to verify the rest of the existing functionality still works.
| Comment | File | Size | Author |
|---|
Issue fork ckeditor_bs_grid-3528374
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
thejimbirch commentedMerge request added that makes Equal the default, selected choice and moved Advanced to the end.
This way, a user does not have to make make any changes on the layout screen and the grid will render as expected.
Comment #4
thejimbirch commentedComment #5
thejimbirch commentedPatch added from the diff of the MR.
Comment #6
b_sharpe commentedComment #7
ruslan piskarovReviewed it on my local project, and I think it is a helpful feature request.
Comment #8
b_sharpe commentedThanks both!