Overview

If by mistake, core_extension.yml contains experience_builder module but without theme xb_stark, installing it with drush si --existing-config, or drush config:import, experience_builder will be installed correctly, but all the interface of XB will be broken missing its theme xb_stark.

Proposed resolution

Add a warning during installation if possible, or in xb pages itself mentionning xb_stark is mandatory.

bug sidebar

User interface changes

CommentFileSizeAuthor
image (6).png107.29 KBheyyo

Issue fork experience_builder-3528368

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

heyyo created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Component: Page builder » Code
Category: Bug report » Task
Priority: Normal » Minor
Status: Active » Postponed (maintainer needs more info)
Issue tags: +DX (Developer Experience)

That’s not really a bug — it requires manual hackery: there’s no way to hit this when installing XB through the UI?

Or what am I overlooking? 🙈

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Postponed (maintainer needs more info) » Active

Yep, I think this would only happen if you had manually modified config files. It seems worth adding a warning because the experience is definitely less than ideal when this happens. Agree that this is minor 👍

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Novice

This should be listed on core’s /admin/reports/status page, using hook_requirements().

s.maklev made their first commit to this issue’s fork.

omkar-pd made their first commit to this issue’s fork.

omkar-pd opened merge request !1112

omkar-pd’s picture

omkar-pd commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Related issues: +#3478287: Introduce the `xb_stark` theme that uses the Semi-Coupled theme engine, removes the need for taking over the Twig theme engine for the whole site

Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Add warning if XB is installed from drupal config but without xb_stark » Warn on status report if XB's `xb_stark` theme was manually uninstalled

  • wim leers committed 9b8ffa4d on 0.x authored by omkar-pd 
    Issue #3528368 by omkar-pd, wim leers, heyyo, lauriii: Warn on status...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.