Overview

This is just the widget - not the dialog

Designs are here - and this Figma should be the canonical source,

CommentFileSizeAuthor
#7 Screenshot 2025-06-20 at 4.36.21 PM.png234.16 KBbnjmnm
Screenshot 2025-06-03 at 9.48.19 PM.png95.99 KBbnjmnm

Issue fork experience_builder-3528288

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm opened merge request !1139

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Issue summary: View changes
Status: Active » Needs review
effulgentsia’s picture

effulgentsia commented
Issue tags: -alpha blocker +beta blocker, +sprint

"alpha blocker" was a typo. This is a blocker for beta.

hooroomoo made their first commit to this issue’s fork.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Status: Needs review » Needs work
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs work » Needs review
StatusFileSize
new Screenshot 2025-06-20 at 4.36.21 PM.png234.16 KB

Looks awesome in Chrome! But in Firefox (my default), the styling gets a little messed up

🤔 I checked this out in Firefox and spotted one thing in the screenshot more (the media titles were wrapping instead of elipsising...) but I'm not entirely sure that would explain how herky jerky that screenshot was... This is how it looks for me now in FF

If you're still having problems, would you be OK looking in the FF inspector and seeing if there are any styles (or lack of) that seem to be making the most nuisance?

jessebaker made their first commit to this issue’s fork.

jessebaker’s picture

jessebaker commented

In the process of reviewing this, I worked with @callumharrod to refine some of the designs to better account for the weights fields and improve the look of the "remove" button.

In working with him, we decided to change the media items to stack in rows instead of the 3 columns. It provides better readability, a better use of space and accounts for media items with longer file names much better.

I've gone ahead and implemented his suggested changes in this MR. I've also given it some pretty thorough testing and a code review and it's all looking good!

(I found one bug that is also present in 0.x - if you have a media widget on the page data side bar, pick some images and then switch to a different sidebar and come back the selected images are no longer shown).

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Related issues: +#3533289: Page data form values-in-progress not retained for Media Library (and perhaps other) fields

#9

(I found one bug that is also present in 0.x - if you have a media widget on the page data side bar, pick some images and then switch to a different sidebar and come back the selected images are no longer shown).

Good catch. I created #3533289: Page data form values-in-progress not retained for Media Library (and perhaps other) fields for this.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Issue summary: View changes

  • bnjmnm committed e1f079ea on 0.x 
    Issue #3528288: Implement Media Library Widget Designs
bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Fixed

@jessebaker reviewed my parts, I reviewed his and @hooroomoo did a pass as well so this is gonna go in.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.