The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
Core's phpunit.xml.dist PHPUnit configuration file flashes some warnings during test discovery under PHPUnit 11, as it keeps supporting PHPUnit 10 directory patterns.
Proposed resolution
Remove the PHPUnit 10 specific configuration while keeping support for PHPUnit 10 for contrib if they need to downgrade.
Remaining tasks
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
Issue fork drupal-3527934
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3527934-remove-support-for
changes, plain diff MR !12392
Comments
Comment #2
mondrakeComment #3
mondrakeComment #5
mondrakeComment #6
catchTagging for 11.3.0 release priority/release notes.
I think if we remove support for running core tests with phpunit 10 but allow it for custom CI pipelines etc., that's a good compromise. The warnings here are currently causing performance tests jobs on 11.2.x to fail with phpunit warnings.
Comment #7
xjm@catch and I discussed this and we think it's probably safe to do in 11.3 as a bridge toward using PHPUnit 12 (or even 13) in D12, so long as we retain the open constraint allowing PHPUnit 10 for contrib/custom CI that hasn't had a chance to update. As @catch stated:
That said, we'd like to re-evaluate this once it's ready for commit just to double-check that there's no additional disruption nor aspects that we missed, so adding the needs RM review tag for that.
I wonder if a CR is enough of a notification about this change, or if we should do a core blog post or something? In the olden days this would have been the sort of thing we announced ahead of time on g.d.o/core but the core blog is a bit more (perhaps too) visible for that. Another thing to consider in our final RM review above.
Anyway great issue! Thank you.
Comment #8
catchI reviewed the issue, kicked off a pgsql and sqlite MR just in case, and ran the phpstan tests optional job, and I can't really see anything to complain about here at all - except that we need a change record and release note. So marking needs work for those, but from the MR perspective looks really good to me.
Comment #9
mondrakeWhile pondering on the CR to write, I realized we can probably do better here. If we do #3530113: Allow indicating alternative phpunit.xml than core's when testing via run-tests.sh first, then we would be able to add here a PHPUnit 10 version of the phpunit.xml (i.e. a copy of the current phpunit.xml.dist in HEAD), and in the CR recommend contrib to switch to use it when running D11 tests with PHPUnit 10. Much neater and less instructions required to tell how to change the xml.
In practice, we would swap the current state where
phpunit.xml.distsupports PHPUnit 10 (and 11 with the warnings triggered), and.phpunit-next.xmlis the PHPUnit 11 only, currently used for testing only. We would end up with aphpunit.xml.distfor PHPUnit 11 only, and a.phpunit-10.xmlfor PHPUnit 10 only.Comment #10
mondrake#3530113: Allow indicating alternative phpunit.xml than core's when testing via run-tests.sh has taken over here. We need an issue to remove PHPUnit 10 support, but let's create a new one instead of reverting this one to its early state.