Problem/Motivation

There is warning for variable $ck5_block_embed_button that is not found so some ajax calls fail as that warning gets injected before the json.

Steps to reproduce

Enable php warning and try to embed block.

Proposed resolution

Figure out why $ck5_block_embed_button is missing from https://git.drupalcode.org/project/ck5_block_embed/-/blob/1.0.x/src/Form...

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 ck5_block_embed_ck5_block_embed_button is not defined-3527925-3.patch1.62 KBhkirsman

Issue fork ck5_block_embed-3527925

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hkirsman created an issue. See original summary.

hkirsman opened merge request !1

hkirsman’s picture

hkirsman commented
StatusFileSize
new ck5_block_embed_ck5_block_embed_button is not defined-3527925-3.patch1.62 KB

Adding also as patch, but of course it needs review as it's not complete yet

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
Status: Active » Reviewed & tested by the community

@hkirsman thanks.

sujan shrestha made their first commit to this issue’s fork.

sujan shrestha’s picture

sujan shrestha commented
Version: 1.0.x-dev » 1.0.2
Status: Reviewed & tested by the community » Fixed

Thank you for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.