Problem/Motivation

It gives a 404, many times if the progress bar is long.

Steps to reproduce

For me it comes up when running civicrm's upgrade in the UI if claro is the theme. It has a progress bar from jquery.ui. I'm not sure if it would come up for anything in drupal core which is probably why it hasn't been noticed.

Proposed resolution

Remove the below css line since it doesn't seem to be doing anything anyway - it looks like it's been there since claro started. My guess is it got accidentally included long ago as a copy/paste reference to drupal 7's misc/progress.gif.

https://git.drupalcode.org/project/drupal/-/blob/a2db325e3fed682474534a2...

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 3526909 after.png168.2 KBcsakiistvan
#10 3526909 before.png288.42 KBcsakiistvan

Issue fork drupal-3526909

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

demeritcowboy created an issue. See original summary.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

fracazo’s picture

fracazo commented

re #1: confirmed on main. find core -name "progress.gif" returns nothing, so the file genuinely doesn't exist.

The same reference also appears in core/themes/default_admin, which looks like it inherited Claro's jQuery UI styles. Four lines total, two source and two compiled:

core/themes/claro/css/components/jquery.ui/theme.pcss.css:719
core/themes/default_admin/css/components/jquery.ui/theme.pcss.css:719

Happy to fix both here, or split default_admin into a follow-up if that's better for scope. Opening an issue fork now.

fracazo opened merge request !16672

fracazo’s picture

fracazo commented

MR https://git.drupalcode.org/project/drupal/-/merge_requests/16672 is up.

Removes the dead progress.gif reference from both Claro and default_admin, source .pcss.css plus regenerated compiled CSS. Rendered output is unchanged since the file 404s today.

fracazo’s picture

fracazo commented
Status: Active » Needs review

MR https://git.drupalcode.org/project/drupal/-/merge_requests/16672 is up.

Removes the dead progress.gif reference from both Claro and default_admin, source .pcss.css plus regenerated compiled CSS. Rendered output is unchanged since the file 404s today.

smustgrave’s picture

smustgrave commented

Can someone check the history and see if it was deleted by accident or in the wrong spot.

demeritcowboy’s picture

demeritcowboy commented

It wasn't there in 8.8 when claro was added: https://git.drupalcode.org/project/drupal/-/tree/8.8.x/core/misc?ref_typ...

And it wasn't there in 8.7 before that either: https://git.drupalcode.org/project/drupal/-/tree/8.7.x/core/misc?ref_typ...

I honestly think it was copy/paste from drupal 7 when claro was even still a contrib module. Compare:

* https://git.drupalcode.org/project/drupal/-/blob/7.x/themes/seven/jquery...
* https://git.drupalcode.org/project/claro/-/blob/8.x-1.0-alpha1/css/src/c...

You can even see here https://git.drupalcode.org/project/claro/-/commit/a5d002eb9d7902dd26946c... when that line was added if you look at the files in the tree on the left there are seven.* files there, further supporting the theory it was copied from the seven theme. And if we go back farther claro clearly started as a seven theme: https://git.drupalcode.org/project/claro/-/commit/98c9448c4cfdfb315c2f51... and those same progress css lines are there just in a different file.

csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: Unassigned » csakiistvan
csakiistvan’s picture

csakiistvan
Primary language Hungarian
Location Budapest, Hungary
commented
Assigned: csakiistvan » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3526909 before.png288.42 KB
new 3526909 after.png168.2 KB

✅ Tested and works — MR !16672.

Environment
  • Drupal: 11.4.4
  • PHP: 8.5.5
  • Database: MariaDB 10.11.16
  • DDEV: v1.25.2
  • Browser: Chrome
Prerequisites
  • MR targets main; all four affected lines are identical in 11.4.4, so the change was applied and verified there.
  • Admin theme set to Claro: ddev drush config:set system.theme admin claro -y
  • Core does not render a jQuery UI progressbar anywhere, so a small test module was used: a route printing <div class="ui-progressbar"><div class="ui-progressbar-value"> with #attached library claro/claro.jquery.ui.
Steps
  1. Apply the fix from MR !16672: drop the url(../../../../misc/progress.gif) part of the .ui-progressbar-value background in Claro and default_admin (source .pcss.css and compiled .css).
  2. Rebuild caches: ddev drush cr
  3. Open the page containing the progressbar with DevTools → Network open and hard-reload.
  4. Compare the requests and the rendered progressbar before and after the change.
Expected results
  • No request for progress.gif and no 404.
  • The progressbar still renders with its background colour — no visual change.
Actual results

Before the change the browser requested /core/themes/misc/progress.gif and got a 404 on every page load of the progressbar; the same reference was present in the served CSS of both Claro and default_admin. After applying MR !16672 the request is gone, the served CSS contains no progress.gif reference, and the progressbar looks unchanged.

Notes
  • The relative path was also wrong: from css/components/jquery.ui/ four levels up resolves to core/themes/misc/progress.gif, not core/misc/. The file exists in neither location, so removing the reference is still the right fix.
  • Confirms #3: four lines total across Claro and default_admin, all covered by the MR.
  • Confirms #7/#8: nothing was deleted by accident — the file is absent in 8.7 and 8.8 as well, so there is no image to restore.

Testing produced with the assistance of an LLM.

  • godotislate committed f0b8514e on 11.x 
    fix: #3526909 progress.gif referenced in claro css doesn't exist

By:...

  • godotislate committed e22fa91d on main 
    fix: #3526909 progress.gif referenced in claro css doesn't exist

By:...
godotislate’s picture

godotislate
he/him
commented
Status: Reviewed & tested by the community » Fixed

Did a string search for any progress references in the codebase and fond nothing relevant.

Committed and pushed e22fa91 to main and f0b8514 to 11.x. Thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

godotislate’s picture

godotislate
he/him
commented
Version: main » 11.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.