Closed (fixed)
Project:
Experience Builder
Version:
1.x-dev
Component:
Config management
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
27 May 2025 at 07:21 UTC
Updated:
12 Aug 2025 at 07:39 UTC
Jump to comment: Most recent
Comments
Comment #2
wim leersComment #3
wim leersComment #4
libbna commentedI will give it a try!
Comment #6
libbna commentedI've implemented a new validation constraint NotNullValueForEveryRequiredSdcProp to ensure that all required props defined in a component's schema have non-null entries in the default_value mapping. This is based on the required array from the component plugin's metadata schema. The logic closely follows the pattern used in KeyForEverySdcProp.
I've tried to achieve the requirement as described—please let me know if anything is missed or needs adjustment.
Comment #7
libbna commentedHi @wim leers to test my code I followed the below steps:
Let me know if this is correct or have I missed anything?Thanks.
Comment #8
wim leersThis is not yet passing tests. 😇 Left a review with pointers.
Comment #9
libbna commentedI resolved the phpstan issue by adding " // @phpstan-ignore argument.type" comment by taking reference from "KeyForEverySdcProp" validator file. Please review and let me know if anymore changes are required.
Unassinging myself so that someone else can work for test cases and keeping the issue to needs work only.
Comment #10
libbna commentedComment #12
thoward216 commentedComment #13
thoward216 commentedComment #14
wim leersThanks, both of you, looks great! 🤩
Comment #16
wim leers