Problem/Motivation
This is a follow-up to #3516579: Automated testing: Configure GitLab CI, where the bare minimum configuration was added to enable automated testing on Gitlab CI.
Validation jobs now report errors in build pipelines, see latest build:
https://git.drupalcode.org/project/config_perms/-/pipelines/504276
- CSPELL: https://git.drupalcode.org/project/config_perms/-/jobs/5343015
- PHPCS: https://git.drupalcode.org/project/config_perms/-/jobs/5343012
- PHPSTAN: https://git.drupalcode.org/project/config_perms/-/jobs/5343041
Steps to reproduce
Run build pipeline at:
https://git.drupalcode.org/project/config_perms/-/pipelines/new
Or each of the jobs listed above separately locally.
Proposed resolution
Fix all validation errors for CSPELL, PHPCS and PHPSTAN.
This was addressed already in a separate merge request but considered out-of-scope, so it was not merged yet:
https://git.drupalcode.org/project/config_perms/-/merge_requests/6
Move over the work that was done previously to a new merge request for this issue specifically.
Issue fork config_perms-3526269
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
dydave commentedQuick follow-up on this issue:
Since all the jobs are now passing 🟢, moving issue to Needs review.
Please note: The changes to require jobs and broaden Tests coverage (GitLab CI config file) are completely at the appreciation and preference of the maintainers.
Feel free to adjust as you would see fit 🙂
Whatever works best for you!
Any feedback, comments or reviews would be greatly appreciated.
Thanks in advance!
Comment #5
mlncn commentedBrought everything in but not making passing the various code style tests required.