Problem/Motivation

There are instances where D.I antipattern exists.
Files like ApiClient.php and Utilities.php

Proposed resolution

Follow Dependency injection anti-patterns referred at https://mglaman.dev/blog/dependency-injection-anti-patterns-drupal

Issue fork acquia_optimize-3526044

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ankitv18 created an issue. See original summary.

ankitv18 opened merge request !8

ankitv18’s picture

ankitv18 commented
Status: Active » Needs review

MR!8 is ready for a review.

vishalkhode’s picture

vishalkhode commented
Status: Needs review » Reviewed & tested by the community

Reviewed changes, looks good to me. Hence, RTBC.

vipin.mittal18’s picture

vipin.mittal18
He/Him
Primary language English
Location Greater Noida, India
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.