Problem/Motivation

The logic around moderationInfo->hasPendingRevision does not work with content_moderation and content translation. It does detect the pending revision for translated entities (non-default language of an entity).

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3526041-2.patch2.89 KBwebflo

Issue fork access_unpublished-3526041

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo commented
Status: Active » Needs review
Related issues: +#3170616: Content Translation interferes when viewing unpublished translations
StatusFileSize
new 3526041-2.patch2.89 KB

webflo opened merge request !22

chr.fritsch made their first commit to this issue’s fork.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Needs work

Needs a rebase

mably made their first commit to this issue’s fork.

mably’s picture

mably commented
Status: Needs work » Needs review

MR has been rebased.

generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented

I'm not 100% sure how to test this one to ensure it's working. I see it has a test, but I'm going to punt this to chr.fritsch or mably to confirm.

mably’s picture

mably commented
Title: Content moderation and translation compabiltity » Content moderation and translation compatibility

When running test-only changes, we can see that, when an entity has a translation in draft state, the getAccessTokenUrl generates a canonical URL for the translation instead of a latest URL as expected.

The MR fixes that.

  • mably committed 9821dfda on 8.x-1.x authored by webflo 
    feat: #3526041 Content moderation and translation compatibility

By:...
mably’s picture

mably commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.