Problem/Motivation

There's scope of minor improvement in the settingsForm.php
for Methods:

  1. getFormId
  2. buildForm
  3. submitForm

Proposed resolution

Use proper return types

Issue fork acquia_optimize-3525988

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ankitv18 created an issue. See original summary.

ankitv18 opened merge request !17

ankitv18 changed the visibility of the branch 3525988-few-minor-improvements to hidden.

ankitv18 opened merge request !28

ankitv18’s picture

ankitv18 commented
Version: 1.1.0 » 1.x-dev
Status: Active » Needs review

vishalkhode made their first commit to this issue’s fork.

vishalkhode’s picture

vishalkhode commented
Status: Needs review » Fixed

Looks good to me.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.