Overview

Postponed on #3525601: Personalization Segment storage: new `Segment` config entity type

Components, regions and templates use the same HTTP internal APIs that allow CRUD operations on our XB-provided config entities.

Personalization Segments should be no different, allowing us to get e.g. auto-save integration for free, while having a consistent API.

Proposed resolution

  • ✅Ensure the HTTP internal config API end-points support personalization segments.
  • ✅Write kernel tests expanding existing tests for segments HTTP internal config API end-points.
  • ✅Expand openapi specs with HTTP internal config API end-points
  • ✅Ensure the HTTP auto-save API end-points support personalization segments.
  • ✅Write kernel tests expanding existing tests for segments HTTP auto-save API end-points.
  • ✅Expand openapi specs with HTTP auto-save API end-points

User interface changes

None.

Issue fork experience_builder-3525608

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

penyaskito created an issue. See original summary.

penyaskito opened merge request !1083

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Assigned: Unassigned » penyaskito
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Postponed » Needs work

Unpostponed.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue summary: View changes

I thought this was ready, but wait, we still need the auto-save integration.
Fixed issue summary.

wim leers changed the visibility of the branch 3525601-personalization-segment-storage to hidden.

wim leers changed the visibility of the branch 3525601-personalization-segment-storage to hidden.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +blocker, +openapi

🏓 Initial review — looking good! A few things can be simplified, and I spotted one bug AFAICT 😇

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue summary: View changes
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: penyaskito » wim leers
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » penyaskito
Status: Needs review » Needs work

Looking good! The key reasons for making Needs work:

  1. found a bug that would prevent the UI from working
  2. a lot of code duplication from XB's existing tests, let's share the non-trivial bits using base classes or traits

Looks like we'll land this later today! :D

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: penyaskito » Unassigned
Status: Needs work » Reviewed & tested by the community

Looks like a solid step forward! 👍

IMHO the next most important thing on the Personalization front is the new ComponentSource plugin. 🤓🙏

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Yes! Moving to #3525728: Personalization ComponentSource plugin: test of fundamental functionality + working tech demo

#3525617: React UI for creating Personalization Segments and potentially most of #3525619: React UI for editing segmentation rules in Personalization Segments are unblocked now!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.