Overview

Postponed on #3525601: Personalization Segment storage: new `Segment` config entity type

We will have a single permission “manage personalization”.
Provide an access control handler for personalization segments.

Proposed resolution

  • ✅ Provide an access control handler for personalization segments using our single permission “manage personalization”. 👈 already happened in #3541148: Provide a locked Default segment.
  • Expand previous kernel tests with permission tests.

User interface changes

None.

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue summary: View changes
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Title: Access control to Personalization Segments » Access control for Personalization Segments
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +stable blocker
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Postponed » Active
effulgentsia’s picture

effulgentsia commented
Issue tags: -stable blocker

Although we're working on Personalization in parallel to trying to get a stable XB 1.0.0 released, the former is not a blocker to the latter. If Personalization itself isn't sufficiently stable by the time we're ready to release XB 1.0.0, we can put it behind a feature flag.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

We need to tackle this before I expected, as by default the status=false won't be exposed via the APIs, and we need to ensure editors have access to them.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Version: 0.x-dev » 1.x-dev
Issue tags: +Needs tests

Provide an access control handler for personalization segments using our single permission “manage personalization”.

This was approved by @lauriii?

If so: 👍

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Assigned: Unassigned » lauriii
Issue tags: +Needs product manager review

Assigning to @lauriii for confirmation, even if we already have the permission in HEAD. This is about adding a access handler to the config entity (probably our existing VisibleWhenDisabledXbConfigEntityAccessControlHandler is more than enough)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Postponed (maintainer needs more info)

@lauriii, see #8.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Assigned: lauriii » Unassigned
Status: Postponed (maintainer needs more info) » Active
Issue tags: -Needs product manager review

I think a single permission for managing the segments is sufficient. 👍

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Access control for Personalization Segments » Access control test coverage for Personalization Segments
Issue summary: View changes
Related issues: +#3541148: Provide a locked Default segment

#3541148: Provide a locked Default segment is about to land and will already add the access control handler. So all that's missing then, is test coverage expansion.

Project: Experience Builder » Drupal Canvas

Experience Builder has been renamed to Drupal Canvas in preparation for its beta release. You can now track issues on the new project page.