Problem/Motivation

While reviewing #3520416: [meta] Handle calls to functions that still require .module file autoloading. one by one I have found a couple more hooks that need exclusion.
hook_update_dependencies cannot be oop, but we don't have rules or documentation excluding it.
Also hook_removed_post_updates

These ones are technically covered by the hooks implemented by theme, but should we add them since they are invoked separately?
THEME_form_system_theme_settings_alter
THEME_views_pre_render
THEME_views_post_render

This isn't really a hook either, but hook like, should we document this:
THEMEPREFIX_engine_settings

Steps to reproduce

N/A

Proposed resolution

Add hook_update_dependencies and hook_removed_post_updates to procedural only and document them.

The remaining ones mentioned in the Problem section are covered by themes documentation. If we want to address those we can create a follow up.

Remaining tasks

Review

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A
None, we're just documenting the already existing behavior.

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3524872

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

Issue summary: View changes
nicxvan’s picture

Issue summary: View changes
nicxvan’s picture

Title: Exclude hook_update_dependencies from OOP hooks » Document and exclude some additional hooks.
nicxvan’s picture

Component: base system » extension system

nicxvan’s picture

Issue summary: View changes
Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Seems pretty straight forward and based on the summary explanation matches the MR.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • catch committed 2829860a on 11.x
    Issue #3524872 by nicxvan: Document and exclude some additional hooks.
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.