Problem/Motivation
While reviewing #3520416: [meta] Handle calls to functions that still require .module file autoloading. one by one I have found a couple more hooks that need exclusion.
hook_update_dependencies cannot be oop, but we don't have rules or documentation excluding it.
Also hook_removed_post_updates
These ones are technically covered by the hooks implemented by theme, but should we add them since they are invoked separately?
THEME_form_system_theme_settings_alter
THEME_views_pre_render
THEME_views_post_render
This isn't really a hook either, but hook like, should we document this:
THEMEPREFIX_engine_settings
Steps to reproduce
N/A
Proposed resolution
Add hook_update_dependencies and hook_removed_post_updates to procedural only and document them.
The remaining ones mentioned in the Problem section are covered by themes documentation. If we want to address those we can create a follow up.
Remaining tasks
Review
User interface changes
N/A
Introduced terminology
N/A
API changes
N/A
None, we're just documenting the already existing behavior.
Data model changes
N/A
Release notes snippet
N/A
Issue fork drupal-3524872
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3524872-document-and-exclude
changes, plain diff MR !12540
Comments
Comment #2
nicxvan commentedComment #3
nicxvan commentedComment #4
nicxvan commentedComment #5
nicxvan commentedComment #7
nicxvan commentedComment #8
smustgrave commentedSeems pretty straight forward and based on the summary explanation matches the MR.
Comment #10
catchCommitted/pushed to 11.x, thanks!