Problem/Motivation

web/modules/contrib/ckeditor5_plugin_pack/modules/ckeditor5_plugin_pack_templates/src/Plugin/CKEditor5Plugin/Template.php
Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

Steps to reproduce

https://git.drupalcode.org/project/ckeditor5_plugin_pack/-/blob/1.3.x/mo...

Install and enable Upgrade Status module, looking at D11 compatibility

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 ckeditor.png102.61 KBraveen_thakur51

Issue fork ckeditor5_plugin_pack-3524534

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

solideogloria created an issue. See original summary.

solideogloria’s picture

solideogloria commented
Issue summary: View changes
solideogloria’s picture

solideogloria commented
Issue summary: View changes
solideogloria’s picture

solideogloria commented
Title: Deprecation warning. » Relying on entity queries to check access by default is deprecated
mdusza’s picture

mdusza commented

Hi solideogloria,

Thank you for reporting the issue, we'll look into it.

raveen_thakur51’s picture

raveen_thakur51 commented
StatusFileSize
new ckeditor.png102.61 KB

Hello guys,
Yes, accessCheck() method on the query and pass TRUE or FALSE to indicate whether access checks should be performed.
=> accessCheck(TRUE): Ensures that access permissions are checked before returning the results.
=> accessCheck(FALSE): Skips permission checking (use only if you’re sure it’s safe and intended).

We Always need to prefer enabling access checks unless you have a specific reason to bypass them.

Thank You

raveen_thakur51 opened merge request !24

raveen_thakur51’s picture

raveen_thakur51 commented
Status: Active » Needs review

salmonek made their first commit to this issue’s fork.

salmonek’s picture

salmonek commented
Status: Needs review » Reviewed & tested by the community

Reviewed, to be released in next version.

salmonek’s picture

salmonek commented

Released in 1.3.2

salmonek’s picture

salmonek commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.