Problem/Motivation

Adding multiple items to the cart will not work when existing=empty because the for loop empty the cart on each loop which cause only the last items to be added to the cart

Steps to reproduce

try to add multiple items by link and set the existing to empty

Proposed resolution

fix the for loop

Remaining tasks

Patch

User interface changes

none

API changes

none

Data model changes

none

CommentFileSizeAuthor
#2 3523807-2.patch1.15 KBanas_maw

Issue fork commerce_cart_links-3523807

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anas_maw created an issue. See original summary.

anas_maw’s picture

anas_maw commented
Status: Active » Needs review
StatusFileSize
new 3523807-2.patch1.15 KB

This patch fix the issue

vmarchuk made their first commit to this issue’s fork.

vmarchuk opened merge request !16

vmarchuk’s picture

vmarchuk
Primary language English
Location Rivne, UA
commented

Also added a fix for the "delete" and empty "existing" parameter as we had the same issue.

  • vmarchuk committed 588137eb on 1.0.x 
    Issue #3523807: Multiple items in cart not working in case of existing=...
vmarchuk’s picture

vmarchuk
Primary language English
Location Rivne, UA
commented
Status: Needs review » Fixed

Committed!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.