Problem/Motivation

The src paths for the column icons on the grid dialog don't include the site's base path, causing them to 404 if the site is not installed at "/". For example, if the site is installed at www.foo.com/bar and uswds_editor_integration is installed via composer, the grid dialog attempts to load www.foo.com/modules/contrib/uswds_editor_integration/images/ui/col_X.png (missing the /bar/ component of the path).

Steps to reproduce

  1. Install a Drupal site with a base path longer than "/"
  2. Install uswds_ckeditor_integration with composer
  3. Add a USWDS Grid component to a CKEditor field and examine the grid configuration dialog

Proposed resolution

Add the site's base path to the beginning of the src attribute of the icons.

Remaining tasks

  1. Figure out how to obtain the site's base path...
  2. Add it to $img in buildSelectStep() of src/Form/GridDialog.php.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork uswds_ckeditor_integration-3523740

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mwymore created an issue. See original summary.

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !97

  • smustgrave committed 36e0fbca on 3.1.x 
    Issue #3523740 by mwymore: Column icons on grid dialog do not respect...
smustgrave’s picture

smustgrave commented
Version: 3.1.3 » 3.1.x-dev
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.