Problem/Motivation

When going to TMGMT admin after enabling TMGMT Ignore Fields has been enabled, we noticed an error :

Got error 'PHP message: PHP Fatal error:  Declaration of Drupal\\tmgmt_ignore_fields\\Plugin\\tmgmt\\Source\\IgnoreFieldsContentEntitySource::extractTranslatableData(Drupal\\Core\\Entity\\ContentEntityInterface $entity): array must be compatible with Drupal\\tmgmt_content\\Plugin\\tmgmt\\Source\\ContentEntitySource::extractTranslatableData(Drupal\\Core\\Entity\\ContentEntityInterface $entity, &$entityRegistry = []) in /opt/www/drupal/web/modules/contrib/tmgmt_ignore_fields/src/Plugin/tmgmt/Source/IgnoreFieldsContentEntitySource.php on line 61'

The weird part is that on our dev server with a similar PHP version we couldn't reproduce it so it might be linked to some custom PHP configuration.

Steps to reproduce

Enable the module, and visit /admin/tmgmt/jobs.

Proposed resolution

Update the signature of extractTranslatableData() to match \Drupal\tmgmt_content\Plugin\tmgmt\Source\ContentEntitySource::extractTranslatableData()

Remaining tasks

MR to be submitted.

User interface changes

None

API changes

None

Data model changes

None

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tostinni created an issue. See original summary.

tostinni’s picture

Status: Active » Needs review

MR submitted

yorickdv’s picture

Status: Needs review » Needs work

Looks fine to me, only the phpcs warning needs to be resolved.

yorickdv’s picture

Status: Needs work » Reviewed & tested by the community

Pipeline has been fixed. Now it looks ready to be merged to me. Will merge this after Security Advisory review of the project.

yorickdv’s picture

yorickdv’s picture

Status: Reviewed & tested by the community » Fixed

This issue has been fixed in 1.0.3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.