Problem/Motivation
When going to TMGMT admin after enabling TMGMT Ignore Fields has been enabled, we noticed an error :
Got error 'PHP message: PHP Fatal error: Declaration of Drupal\\tmgmt_ignore_fields\\Plugin\\tmgmt\\Source\\IgnoreFieldsContentEntitySource::extractTranslatableData(Drupal\\Core\\Entity\\ContentEntityInterface $entity): array must be compatible with Drupal\\tmgmt_content\\Plugin\\tmgmt\\Source\\ContentEntitySource::extractTranslatableData(Drupal\\Core\\Entity\\ContentEntityInterface $entity, &$entityRegistry = []) in /opt/www/drupal/web/modules/contrib/tmgmt_ignore_fields/src/Plugin/tmgmt/Source/IgnoreFieldsContentEntitySource.php on line 61'
The weird part is that on our dev server with a similar PHP version we couldn't reproduce it so it might be linked to some custom PHP configuration.
Steps to reproduce
Enable the module, and visit /admin/tmgmt/jobs.
Proposed resolution
Update the signature of extractTranslatableData() to match \Drupal\tmgmt_content\Plugin\tmgmt\Source\ContentEntitySource::extractTranslatableData()
Remaining tasks
MR to be submitted.
User interface changes
None
API changes
None
Data model changes
None
Comments
Comment #3
tostinni commentedMR submitted
Comment #4
yorickdv commentedLooks fine to me, only the phpcs warning needs to be resolved.
Comment #5
yorickdv commentedPipeline has been fixed. Now it looks ready to be merged to me. Will merge this after Security Advisory review of the project.
Comment #6
yorickdv commentedComment #7
yorickdv commentedThis issue has been fixed in 1.0.3