Problem/Motivation

Immediately after updating 3.2.0-rc1 => 3.2.0-rc2 out ToCs are broken with the following appearing in the JavaScript console...

drupal.js?v=10.4.6:64 Uncaught TypeError: Cannot read properties of null (reading 'match')
    at getStyleValueFromCssProperty (toc_js.js?svjbte:33:45)
    at toc_js.js?svjbte:145:32
    at Array.forEach (<anonymous>)
    at Object.attach (toc_js.js?svjbte:97:42)
    at drupal.js?v=10.4.6:166:24
    at Array.forEach (<anonymous>)
    at Object.attachBehaviors (drupal.js?v=10.4.6:162:34)
    at drupal.init.js?v=10.4.6:32:12
    at HTMLDocument.listener (drupal.init.js?v=10.4.6:20:7)

Downgrading back to 3.2.0-rc1 fixes the problem.

Issue fork toc_js-3522124

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sirclickalot created an issue. See original summary.

sirclickalot’s picture

sirclickalot
Primary language English
Location Somerset
commented
Issue summary: View changes

mably made their first commit to this issue’s fork.

mably opened merge request !40

mably’s picture

mably commented
Component: Documentation » Code
Status: Active » Needs review

Hi @sirclickalot, could you give a try to this issue's MR and see if it fixes your problem?

We really need to initialize some basic functional tests...

But thanks a lot for giving a try to our new releases.

sirclickalot’s picture

sirclickalot
Primary language English
Location Somerset
commented

Hi @mably,

Yes, I can confirm that updating to 3.2.0-rc2 and applying 40.patch from merge_requests/40 fixe the issue for me.

  • mably committed 6635c26c on 3.x 
    Issue #3522124 by sirclickalot, mably: Broken since update to Upgrading(...
mably’s picture

mably commented
Status: Needs review » Fixed

Thanks for the patch testing @sirclickalot, it's merged!

And released.

And a first functional javascript test was written.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.