Problem/Motivation
Coming from #3520384: Append views display type to element name:
Lupus CE renderer correctly adds this cache contexts:
'url.query_args:_content_format',
'url.query_args:_select',
But that's apparently not enough, since the content-format can be set via request attribute as well - as done by lupus_decoupled_ce_api.
Steps to reproduce
see ##3520384: Append views display type to element name
Proposed resolution
That means, lupus_ce_renderer should expose this is a new cache context which works like getContentFormatFromRequest() method.
Then we can replace our url.query_args._content_format cache context with the new cache context.
Issue fork lupus_ce_renderer-3520910
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
useernamee commentedComment #4
fagoAdded MR including test coverage. I also verified manually that the change fixes the described issue.
Comment #5
useernamee commentedOne things that needs a check is that ContentFormatCacheContext needs to implement an interface.
Kernel test is passing.
Comment #6
fagothx. I addressed your remarks, either fixed or commented - see comments above!
Comment #7
useernamee commentedAll PR comments are resolved. RTBC
Comment #9
fagoComment #10
useernamee commentedTested locally and it fixes the issue described in the ticket.
**offtopic** I had some issues testing it locally with the layour_builder integration. Which I had to disable to test.