Problem/Motivation

The government banner theme implementation defines image_base as the path for images within the template, but the template uses uswds_images instead.

Steps to reproduce

The definition is in uswds_base_theme: https://git.drupalcode.org/project/uswds_base/-/blob/3.10.x/uswds_base.theme?ref_type=heads#L21

The render array is provided to the page.html.twig template in uswds_base_preprocess_page: https://git.drupalcode.org/project/uswds_base/-/blob/3.10.x/preprocess/layout/page.preprocess.inc?ref_type=heads#L60

The template uses uswds_images from uswds_base_preprocess instead of image_base: https://git.drupalcode.org/project/uswds_base/-/blob/3.10.x/templates/uswds/government-banner.html.twig?ref_type=heads#L16

Proposed resolution

There are 2 options:

  • Use image_base in the templates
  • Remove image_base variable that is not used

Remaining tasks

TBD

User interface changes

None

API changes

None

Data model changes

None

Issue fork uswds_base-3520842

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tregonia created an issue. See original summary.

mferanda made their first commit to this issue’s fork.

mferanda opened merge request !86

  • mferanda committed f27b9cc8 on 3.10.x 
    Resolve #3520842 "Government banner defines"
mferanda’s picture

mferanda commented
Category: Bug report » Task

Changing to task since this is a cleanup, not a bug.

mferanda’s picture

mferanda commented
Status: Active » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

mferanda’s picture

mferanda commented
Status: Fixed » Closed (fixed)