Closed (fixed)
Project:
Experience Builder
Version:
0.x-dev
Component:
Theme builder
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Apr 2025 at 10:45 UTC
Updated:
13 May 2025 at 19:09 UTC
Jump to comment: Most recent

Comments
Comment #2
wim leersThis was definitely a bug while #3518185: Store imported JS components in `JavaScriptComponent` (and reflect in config dependencies) was in without #3518198: Set code component dependencies and support code editor preview based on import statements having landed.
It seems that has not yet taken advantage of #3508140: PATCH request for config entities reset values that are not sent, and is hence doing more than just setting
status: true, because the error message literally says what's going on:compiled_jsorsource_code_jsare being sent, which then also requiresimported_js_componentsto be sent.The UI should surface the validation errors provided by the server explicitly, instead of telling the user to look at the browser console, by doing #3503547: Display validation errors in dialogs that create sections.
Comment #3
hooroomoo#3513147: Using actions from the contextual menu from the sidebar list overrides code component with its latest non-autosaved version is supposed to update the client PATCH requests to only include the wanted changes instead of also including the compiled/source_js in the request which I started on in this MR: https://git.drupalcode.org/project/experience_builder/-/merge_requests/9...
But currently doing that results in the component not working in the preview, I think due to something with the auto-save. I am hoping #3519634: Modifying a XB config entity's `status` or `label` should update the auto-save entry too, rather than delete it will unblock #3513147: Using actions from the contextual menu from the sidebar list overrides code component with its latest non-autosaved version which would then fix this issue.
Comment #4
wim leersWhat are the symptoms? And that is specifically when trying the #3513147: Using actions from the contextual menu from the sidebar list overrides code component with its latest non-autosaved version MR? Is that what #3513147-8: Using actions from the contextual menu from the sidebar list overrides code component with its latest non-autosaved version is about?
Comment #5
hooroomoo#3519634: Modifying a XB config entity's `status` or `label` should update the auto-save entry too, rather than delete it got merged which includes updating the client PATCH requests to only send what is necessary (therefore not triggering the error) which fixes this bug
Comment #6
hooroomooComment #7
wim leers#5: 🥳 — I did see that in the diff, and was wondering about this :D