Problem/Motivation

\Drupal\smart_date\Plugin\Field\FieldFormatter\SmartDateFormatterBase is used as basis class for the field formatter and can not be used as standalone formatter. Same with 

\Drupal\smart_date\Plugin\Field\FieldWidget\SmartDateWidgetBase

and \Drupal\Tests\smart_date\Functional\SmartDateTestBase.

Steps to reproduce

-

Proposed resolution

Declare classes as abstract.

Remaining tasks

-

User interface changes

-

API changes

-

Data model changes

-

Issue fork smart_date-3520224

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tobiasb created an issue. See original summary.

tobiasb opened merge request !175

tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Assigned: tobiasb » Unassigned
Status: Active » Needs review
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Title: Declare SmartDateFormatterBase as abtract » Declare base classes as abtract
Issue summary: View changes
tobiasb’s picture

tobiasb
Primary language German
Location Berlin
commented
Issue summary: View changes

tyapchyc made their first commit to this issue’s fork.

  • tyapchyc committed 71161899 on 4.2.x authored by tobiasb 
    Issue #3520224 by tobiasb: Declare base classes as abtract
tyapchyc’s picture

tyapchyc commented
Status: Needs review » Fixed

Thanks for pointing this out and providing the fix. Merged — much appreciated!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.